Add refactoring to replace ! with .Value #11227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
reviewed
Mar 12, 2021
vsintegration/src/FSharp.Editor/Refactor/ChangeDerefToValueRefactoring.fs
Outdated
Show resolved
Hide resolved
cartermp
commented
Mar 14, 2021
| @@ -46,6 +46,9 @@ type public FSharpParseFileResults = | |||
| /// </summary> | |||
| member TryRangeOfRefCellDereferenceContainingPos: expressionPos: pos -> range option | |||
|
|
|||
| /// Gets the range of an expression being dereferenced. For `!expr`, gives the range of `expr` | |||
| member TryRangeOfExpressionBeingDereferencedContainingPos: expressionPos: pos -> range option | |||
There was a problem hiding this comment.
A more efficient approach is to unify this with TryRangeOfRefCellDereferenceContainingPos. This would be a breaking change, but we're already doing several breaks in FCS 40.
KevinRansom
approved these changes
Mar 19, 2021
| member _.VisitExpr(_, _, defaultTraverse, expr) = | ||
| match expr with | ||
| | SynExpr.App(_, false, SynExpr.Ident funcIdent, expr, _) -> | ||
| if funcIdent.idText = "op_Dereference" && rangeContainsPos expr.Range expressionPos then |
There was a problem hiding this comment.
Not for this PR, but perhaps we should consider an enum for id constants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help with: fsharp/fslang-suggestions#569